fix(Migrator): disable foreign keys during DropColumn#229
Merged
Conversation
DropColumn calls recreateTable which performs DROP TABLE + INSERT INTO + ALTER TABLE RENAME. When foreign keys are enabled, SQLite enforces FK constraints on the INSERT INTO step, causing the operation to fail. Wrap DropColumn in RunWithoutForeignKey, following the same pattern already used by AlterColumn and DropTable. Closes #119
h2zi
added a commit
to libtnb/sqlite
that referenced
this pull request
Jul 7, 2026
- AlterColumn/DropColumn: accept a table-name string without panicking (stmt.Schema is nil then, as in other GORM dialects) - disable foreign keys during DropColumn/CreateConstraint/DropConstraint table rebuilds (go-gorm/sqlite#229) and pin the PRAGMAs plus the rebuild transaction to a single pool connection - recreateTable: recreate indexes and triggers dropped with the old table, and rename via legacy_alter_table so tables referenced by views can be rebuilt (go-gorm/sqlite#225) - HasColumn: exact match via pragma_table_info instead of LIKE substring matching over the DDL, which had false positives - HasConstraint: exact constraint-name match via DDL parsing - GetTables: exclude sqlite_* internal tables - ColumnTypes: don't let rows.Close() overwrite an earlier error - getRawDDL: report "table not found" instead of "invalid DDL" - DropColumn: fail when the column isn't present in the DDL Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #119
Problem
DropColumn fails when foreign keys are enabled because it calls recreateTable, which performs DROP TABLE + INSERT INTO + ALTER TABLE RENAME. SQLite enforces FK constraints on the INSERT INTO step, causing the operation to fail with constraint violation errors.
Solution
Wrap DropColumn in RunWithoutForeignKey, following the exact same pattern already used by AlterColumn and DropTable in this file.
Before
After